Merged
Conversation
Add billing_cycles_count (writable), channels_included_count (read-only), and address_verification relationship per swagger spec.
Per swagger spec, AvailableDid has a nanpa_prefix relationship.
Per swagger spec, DidGroup has a requirement relationship.
Per swagger spec, Identity has a writable contact_email attribute.
Per swagger spec, VoiceInTrunkGroup has a read-only created_at attribute.
Add read-only reference attribute per swagger spec. Change reject_reasons from List<String> to String to match swagger and PHP SDK.
Proof entity can be either Identity or Address. Implement using ProofEntity marker interface that both classes implement, which jsonapi-converter supports for polymorphic relationships. Add tests for serialization of both identity and address entity cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.